Update Firefox support for Crash Reporting API#29782
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
|
I am not sure about this (yet). I mean - I know they are technically different things but adding a context would reasonably change what is the report. Asking in https://bugzilla.mozilla.org/show_bug.cgi?id=2036160#c4 |
|
Thanks for checking. I agree this should wait for the needinfo on https://bugzilla.mozilla.org/show_bug.cgi?id=2036160#c4. The pref is present and Nightly-only by default, and the BCD entries are now marked |
|
@hamishwillee I tried to CC myself into the Bugzilla case but it seems like I cannot write anything there. Do you mind adding my same mail which is in its CC allowing the appropriate permission? :) |
Yes I do mind. |
Problem
Firefox 152 enables the Crash Reporting API in Nightly builds via
dom.reporting.crash.enabled, but BCD still listed the CrashReportContext storage APIs as unsupported in Firefox.Root cause
The Gecko change only flips the Crash Reporting API preference for Nightly builds, so the existing Chromium-only data needed Firefox support entries behind that preference.
Solution
Update Firefox support for:
api.CrashReportContextapi.CrashReportContext.deleteapi.CrashReportContext.initializeapi.CrashReportContext.setapi.Window.crashReportEach entry is marked as added in Firefox 152 behind
dom.reporting.crash.enabled.Tests
npx --yes npm@11.12.1 --prefix C:\Users\kirti\Documents\PRs\browser-compat-data run lint -- api/CrashReportContext.json api/Window.jsonC:\Users\kirti\Documents\PRs\browser-compat-data\node_modules\.bin\prettier.cmd --check C:\Users\kirti\Documents\PRs\browser-compat-data\api\CrashReportContext.json C:\Users\kirti\Documents\PRs\browser-compat-data\api\Window.jsonnode -e "const fs=require('fs'); for (const f of ['C:/Users/kirti/Documents/PRs/browser-compat-data/api/CrashReportContext.json','C:/Users/kirti/Documents/PRs/browser-compat-data/api/Window.json']) JSON.parse(fs.readFileSync(f,'utf8')); console.log('JSON OK')"git diff --checkReferences